Conversation
and try cpp-linter-action v3.0-rc0 branch
Cpp-Linter Report
|
keeps build artifacts in the build/ folder
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v17.0.6
Used clang-tidy v17.0.1
Only 8 out of 10 concerns fit within this pull request's diff.
Click here for a patch of fixes outside the diff
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +3,0 @@
-
-
@@ -14,19 +12,1 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {Have any feedback or feature suggestions? Share it here.
Comment on lines
1
to
2
| /** This is a very ugly test code (doomed to fail linting) */ | ||
| #include "demo.hpp" |
There was a problem hiding this comment.
clang-tidy diagnostic(s)
- included header demo.hpp is not used directly [misc-include-cleaner]
Suggested change
| /** This is a very ugly test code (doomed to fail linting) */ | |
| #include "demo.hpp" | |
| #include <cstdio> |
| #include "demo.hpp" | ||
| #include <cstdio> | ||
| #include <cstddef> | ||
| #include <stdio.h> |
There was a problem hiding this comment.
clang-tidy diagnostic(s)
- inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
Suggested change
| #include <stdio.h> | |
| auto main() -> int | |
| { |
Comment on lines
5
to
+10
|
|
||
| int main() | ||
| { | ||
| for (;;) | ||
| break; | ||
|
|
||
|
|
||
| int main(){ | ||
|
|
||
| for (;;) break; |
There was a problem hiding this comment.
clang-tidy diagnostic(s)
- use a trailing return type for this function [modernize-use-trailing-return-type]
- statement should be inside braces [readability-braces-around-statements]
Suggested change
| int main() | |
| { | |
| for (;;) | |
| break; | |
| int main(){ | |
| for (;;) break; | |
| for (;;) { | |
| break; | |
| } |
Comment on lines
14
to
+17
|
|
||
| return 0; | ||
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| return 0; | |
| } | |
| return 0; | |
| } |
| for (;;) break; | ||
|
|
||
|
|
||
| printf("Hello world!\n"); |
There was a problem hiding this comment.
clang-tidy diagnostic
src/demo.cpp:13:5 warning: [cppcoreguidelines-pro-type-vararg]
do not call c-style vararg functions
13 | printf("Hello world!\n");
| ^
Comment on lines
5
to
7
| class Dummy { | ||
| char* useless; | ||
| int numb; |
There was a problem hiding this comment.
clang-tidy diagnostic(s)
- use default member initializer for 'useless' [cppcoreguidelines-use-default-member-init]
- use default member initializer for 'numb' [cppcoreguidelines-use-default-member-init]
Suggested change
| class Dummy { | |
| char* useless; | |
| int numb; | |
| char* useless { "\0" }; | |
| int numb { 0 }; | |
| Dummy() { } |
Comment on lines
9
to
10
|
|
||
| public: |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| public: | |
| public: | |
| auto not_useful(char* str) -> void* { useless = str; } |
| struct LongDiff | ||
| { | ||
|
|
||
| long diff; |
There was a problem hiding this comment.
clang-tidy suggestion
Please remove the line(s)
- 34
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v17.0.6
Used clang-tidy v17.0.1
Only 8 out of 10 concerns fit within this pull request's diff.
8 suggestions were duplicates of previous reviews.
Click here for a patch of fixes outside the diff
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -3,2 +3,0 @@
-
-
@@ -14,19 +12,1 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-struct LongDiff
-{
+struct LongDiff {Have any feedback or feature suggestions? Share it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now with PR review suggestions unified (from both tools) and thread comments that boast available auto-fixes.